cloud-fan commented on code in PR #40688:
URL: https://github.com/apache/spark/pull/40688#discussion_r1161845550
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -118,6 +118,7 @@ case class AdaptiveSparkPlanExec(
val ensureRequirements =
EnsureRequirements(requiredDistribution.isDefined, requiredDistribution)
Seq(
+ CoalesceBucketsInJoin,
Review Comment:
Can we spend a bit of time understanding why? Then we can write a code
comment to explain it and following developers won't try to move this rule to
`queryStageOptimizerRules` ever.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -118,6 +118,7 @@ case class AdaptiveSparkPlanExec(
val ensureRequirements =
EnsureRequirements(requiredDistribution.isDefined, requiredDistribution)
Seq(
+ CoalesceBucketsInJoin,
Review Comment:
Can we spend a bit of time understanding why? Then we can write a code
comment to explain it and future developers won't try to move this rule to
`queryStageOptimizerRules` ever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
