zzzzming95 commented on code in PR #40688:
URL: https://github.com/apache/spark/pull/40688#discussion_r1162910204
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -118,6 +118,7 @@ case class AdaptiveSparkPlanExec(
val ensureRequirements =
EnsureRequirements(requiredDistribution.isDefined, requiredDistribution)
Seq(
+ CoalesceBucketsInJoin,
Review Comment:
Because `queryStageOptimizerRules` is not applied at the beginning of the
init plan. Instead, they are applied in the `createQueryStages()` method. And
`createQueryStages()` is bottom-up, which causes the exchange to be eliminated
to be wrapped in a layer of `ShuffleQueryStage` first, making
`CoalesceBucketsInJoin` unrecognizable. And I have added these to the notes at
the top. thanks @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
