wangyum opened a new pull request, #40742:
URL: https://github.com/apache/spark/pull/40742
### What changes were proposed in this pull request?
This PR filters out `EqualNullSafe` generated by
`UnaryNode.getAllValidConstraints` in `InferFiltersFromConstraints`.
### Why are the changes needed?
Avoid Once strategy's idempotence is broken for batch: `Infer Filters`:
```sql
export SPARK_TESTING=1
CREATE TABLE t1 (i INT, j INT, k STRING) USING parquet;
CREATE TABLE t2 (i INT, j INT, k STRING) USING parquet;
CREATE TABLE t3 (i INT, j INT, k STRING) USING parquet;
SELECT *
FROM (SELECT t1.i, t1.i as t1i
FROM t1 JOIN t3 ON t1.i = t3.i) t
JOIN t2 ON t.i = t2.i;
```
Before this PR:
```
=== Applying Rule
org.apache.spark.sql.catalyst.optimizer.InferFiltersFromConstraints ===
Join Inner, (i#72 = i#78)
Join Inner, (i#72 = i#78)
!:- Project [i#72, i#72 AS t1i#71] :-
Filter ((i#72 <=> i#72) AND (t1i#71 <=> t1i#71))
!: +- Join Inner, (i#72 = i#75) :
+- Project [i#72, i#72 AS t1i#71]
!: :- Project [i#72] :
+- Join Inner, (i#72 = i#75)
!: : +- Relation spark_catalog.default.t1[i#72,j#73,k#74] parquet :
:- Filter isnotnull(i#72)
!: +- Project [i#75] :
: +- Project [i#72]
!: +- Relation spark_catalog.default.t3[i#75,j#76,k#77] parquet :
: +- Relation spark_catalog.default.t1[i#72,j#73,k#74] parquet
!+- Relation spark_catalog.default.t2[i#78,j#79,k#80] parquet :
+- Filter isnotnull(i#75)
! :
+- Project [i#75]
! :
+- Relation spark_catalog.default.t3[i#75,j#76,k#77] parquet
! +-
Filter isnotnull(i#78)
!
+- Relation spark_catalog.default.t2[i#78,j#79,k#80] parquet
org.apache.spark.SparkRuntimeException: Once strategy's idempotence is
broken for batch Infer Filters
Join Inner, (i#72 = i#78)
Join Inner, (i#72 = i#78)
:- Filter ((i#72 <=> i#72) AND (t1i#71 <=> t1i#71))
:- Filter ((i#72 <=> i#72) AND (t1i#71 <=> t1i#71))
: +- Project [i#72, i#72 AS t1i#71]
: +- Project [i#72, i#72 AS t1i#71]
: +- Join Inner, (i#72 = i#75)
: +- Join Inner, (i#72 = i#75)
: :- Filter isnotnull(i#72)
: :- Filter isnotnull(i#72)
: : +- Project [i#72]
: : +- Project [i#72]
: : +- Relation spark_catalog.default.t1[i#72,j#73,k#74] parquet
: : +- Relation spark_catalog.default.t1[i#72,j#73,k#74] parquet
: +- Filter isnotnull(i#75)
: +- Filter isnotnull(i#75)
: +- Project [i#75]
: +- Project [i#75]
: +- Relation spark_catalog.default.t3[i#75,j#76,k#77] parquet
: +- Relation spark_catalog.default.t3[i#75,j#76,k#77] parquet
!+- Filter isnotnull(i#78)
+- Filter (i#78 <=> i#78)
! +- Relation spark_catalog.default.t2[i#78,j#79,k#80] parquet
+- Filter isnotnull(i#78)
!
+- Relation spark_catalog.default.t2[i#78,j#79,k#80] parquet.
```
After this PR:
```
=== Applying Rule
org.apache.spark.sql.catalyst.optimizer.InferFiltersFromConstraints ===
Join Inner, (i#72 = i#78)
Join Inner, (i#72 = i#78)
:- Project [i#72, i#72 AS t1i#71] :-
Project [i#72, i#72 AS t1i#71]
: +- Join Inner, (i#72 = i#75) :
+- Join Inner, (i#72 = i#75)
!: :- Project [i#72] :
:- Filter isnotnull(i#72)
!: : +- Relation spark_catalog.default.t1[i#72,j#73,k#74] parquet :
: +- Project [i#72]
!: +- Project [i#75] :
: +- Relation spark_catalog.default.t1[i#72,j#73,k#74] parquet
!: +- Relation spark_catalog.default.t3[i#75,j#76,k#77] parquet :
+- Filter isnotnull(i#75)
!+- Relation spark_catalog.default.t2[i#78,j#79,k#80] parquet :
+- Project [i#75]
! :
+- Relation spark_catalog.default.t3[i#75,j#76,k#77] parquet
! +-
Filter isnotnull(i#78)
!
+- Relation spark_catalog.default.t2[i#78,j#79,k#80] parquet
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
