cloud-fan commented on code in PR #40742:
URL: https://github.com/apache/spark/pull/40742#discussion_r1165107619
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala:
##########
@@ -75,7 +75,10 @@ trait ConstraintHelper {
inferredConstraints ++= replaceConstraints(predicates - eq, l, r)
case _ => // No inference
}
- inferredConstraints -- constraints
+ (inferredConstraints -- constraints).filterNot {
Review Comment:
shall we update the pattern match before to add `if !l.semanticEquals(r)`?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala:
##########
@@ -75,7 +75,10 @@ trait ConstraintHelper {
inferredConstraints ++= replaceConstraints(predicates - eq, l, r)
case _ => // No inference
}
- inferredConstraints -- constraints
+ (inferredConstraints -- constraints).filterNot {
Review Comment:
shall we update the pattern match above to add `if !l.semanticEquals(r)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
