HyukjinKwon commented on code in PR #40747:
URL: https://github.com/apache/spark/pull/40747#discussion_r1164039163
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -50,7 +50,7 @@ trait FunctionRegistryBase[T] {
final def registerFunction(
name: FunctionIdentifier, builder: FunctionBuilder, source: String):
Unit = {
val info = new ExpressionInfo(
- builder.getClass.getCanonicalName,
+ builder.getClass.getName,
Review Comment:
The change itself is probably fine because it's not used anymore (at least
within Spark project) as far as I remember.
But why don't we go more conservative with a check if this is null then use
`builder.getClass.getName`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
