HyukjinKwon commented on code in PR #40747:
URL: https://github.com/apache/spark/pull/40747#discussion_r1166248736


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -49,8 +49,10 @@ trait FunctionRegistryBase[T] {
 
   final def registerFunction(
       name: FunctionIdentifier, builder: FunctionBuilder, source: String): 
Unit = {
+    var builderClassName = builder.getClass.getCanonicalName

Review Comment:
   no biggie but I would add a single comment that we're doing this for 
anonymous class name returning `null` in jdk 17 (with JIRA ID)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to