wangyum commented on code in PR #40688:
URL: https://github.com/apache/spark/pull/40688#discussion_r1164945605
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala:
##########
@@ -1020,21 +1019,25 @@ abstract class BucketedReadSuite extends QueryTest with
SQLTestUtils with Adapti
SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "0",
SQLConf.COALESCE_BUCKETS_IN_JOIN_ENABLED.key -> "true") {
def verify(
- query: String,
- expectedNumShuffles: Int,
- expectedCoalescedNumBuckets: Option[Int]): Unit = {
- val plan = sql(query).queryExecution.executedPlan
- val shuffles = plan.collect { case s: ShuffleExchangeExec => s }
- assert(shuffles.length == expectedNumShuffles)
-
- val scans = plan.collect {
- case f: FileSourceScanExec if
f.optionalNumCoalescedBuckets.isDefined => f
- }
- if (expectedCoalescedNumBuckets.isDefined) {
- assert(scans.length == 1)
- assert(scans.head.optionalNumCoalescedBuckets ==
expectedCoalescedNumBuckets)
- } else {
- assert(scans.isEmpty)
+ query: String,
+ expectedNumShuffles: Int,
+ expectedCoalescedNumBuckets: Option[Int]): Unit = {
Review Comment:
```suggestion
query: String,
expectedNumShuffles: Int,
expectedCoalescedNumBuckets: Option[Int]): Unit = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
