cloud-fan commented on code in PR #40742:
URL: https://github.com/apache/spark/pull/40742#discussion_r1165439256
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala:
##########
@@ -66,13 +66,13 @@ trait ConstraintHelper {
val predicates = constraints.filterNot(_.isInstanceOf[IsNotNull])
predicates.foreach {
case eq @ EqualTo(l: Attribute, r: Attribute) =>
- val candidateConstraints = predicates - eq
+ val candidateConstraints = predicates - eq - EqualNullSafe(l, r)
Review Comment:
can you explain it a bit more about why it makes the optimizer not idempot?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala:
##########
@@ -66,13 +66,13 @@ trait ConstraintHelper {
val predicates = constraints.filterNot(_.isInstanceOf[IsNotNull])
predicates.foreach {
case eq @ EqualTo(l: Attribute, r: Attribute) =>
- val candidateConstraints = predicates - eq
+ val candidateConstraints = predicates - eq - EqualNullSafe(l, r)
Review Comment:
can you explain it a bit more about why it makes the optimizer not
idempotent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
