gengliangwang commented on code in PR #40732:
URL: https://github.com/apache/spark/pull/40732#discussion_r1166036014
##########
sql/core/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveDefaultColumnsSuite.scala:
##########
@@ -24,7 +24,7 @@ import org.apache.spark.sql.test.SharedSparkSession
import org.apache.spark.sql.types.{StructField, StructType, TimestampType}
class ResolveDefaultColumnsSuite extends QueryTest with SharedSparkSession {
- val rule = ResolveDefaultColumns(catalog = null)
+ val rule = ResolveDefaultColumns(null)
Review Comment:
why passing a `null` here and the new test case still passes? I wonder if
the code changes are tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
