dtenedor commented on code in PR #40732:
URL: https://github.com/apache/spark/pull/40732#discussion_r1166042080
##########
sql/core/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveDefaultColumnsSuite.scala:
##########
@@ -24,7 +24,7 @@ import org.apache.spark.sql.test.SharedSparkSession
import org.apache.spark.sql.types.{StructField, StructType, TimestampType}
class ResolveDefaultColumnsSuite extends QueryTest with SharedSparkSession {
- val rule = ResolveDefaultColumns(catalog = null)
+ val rule = ResolveDefaultColumns(null)
Review Comment:
Good question, as discussed offline: This `rule` field in this unit test
just exercises the `addMissingDefaultValuesForInsertFromInlineTable` method
directly. This never uses the `resolveRelation` method anyway. This applies to
the first two test cases only. (I prototyped moving `ResolveDefaultColumns`
out of the `Analyzer` class to make passing this unnecessary, but this proved
more complex than the scope of this PR; I can explore separately).
The last two cases use SQL to cover the new code changes, which exercises
the `ResolveDefaultColumns` rule instance in the analyzer instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
