cloud-fan commented on code in PR #37879:
URL: https://github.com/apache/spark/pull/37879#discussion_r1170689458
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -216,19 +216,23 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
c
}
- case DropTable(ResolvedV1TableIdentifier(ident), ifExists, purge) =>
+ case DropTable(ResolvedV1Identifier(ident), ifExists, purge) =>
Review Comment:
The change here is necessary as we don't look up the table for DROP TABLE
anymore, so we can only "guess" it's a v1 or v2 table by the identifier.
I don't have a good solution here unless we add back the table lookup for
DROP TABLE. Or shall we remove v1 DROP TABLE entirely? This is a very simple
command and I think the v2 command covers it very well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
