cloud-fan commented on code in PR #37879:
URL: https://github.com/apache/spark/pull/37879#discussion_r1171982232
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -216,19 +216,23 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
c
}
- case DropTable(ResolvedV1TableIdentifier(ident), ifExists, purge) =>
+ case DropTable(ResolvedV1Identifier(ident), ifExists, purge) =>
Review Comment:
`exists` should be slightly faster than `load` as the RPC message is
smaller. I think we can further optimize out `exists` and send one RPC to drop
the table. If the table doesn't exist, false will be returned and we can deal
with it in the client (Spark) side to implement the `if exists` semantic.
This PR also makes the third-party access control service clearer: ideally
people don't need SELECT permission to drop a table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
