HyukjinKwon commented on code in PR #40834:
URL: https://github.com/apache/spark/pull/40834#discussion_r1173384461
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -750,7 +751,8 @@ class SparkConnectPlanner(val session: SparkSession) {
}
cols
}
- Deduplicate(groupCols, queryExecution.analyzed)
+ if (rel.getWithinWatermark) DeduplicateWithinWatermark(groupCols,
queryExecution.analyzed)
Review Comment:
Okay, just noticed that it was discussed at
https://github.com/apache/spark/pull/40834#discussion_r1170693559. I will go
ahead and merge if you guys don't have preference. I don't feel strongly about
this either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
