amaliujia commented on code in PR #40834:
URL: https://github.com/apache/spark/pull/40834#discussion_r1174195181
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -750,7 +751,8 @@ class SparkConnectPlanner(val session: SparkSession) {
}
cols
}
- Deduplicate(groupCols, queryExecution.analyzed)
+ if (rel.getWithinWatermark) DeduplicateWithinWatermark(groupCols,
queryExecution.analyzed)
Review Comment:
If there is anything wrong, I think deprecating a field is easier than
deprecating a new relation type. Probably starting from this by adding a new
flag way is a good beginning.
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -750,7 +751,8 @@ class SparkConnectPlanner(val session: SparkSession) {
}
cols
}
- Deduplicate(groupCols, queryExecution.analyzed)
+ if (rel.getWithinWatermark) DeduplicateWithinWatermark(groupCols,
queryExecution.analyzed)
Review Comment:
If there is anything wrong, I think deprecating a field is easier than
deprecating a new relation type. Probably starting from this by adding a new
flag is a good beginning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
