rshkv commented on code in PR #40902:
URL: https://github.com/apache/spark/pull/40902#discussion_r1174400261
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala:
##########
@@ -27,18 +27,18 @@ import org.apache.spark.sql.types.{IntegerType, StringType,
StructField, StructT
class DataSourceStrategySuite extends PlanTest with SharedSparkSession {
val attrInts = Seq(
$"cint".int,
- $"c.int".int,
+ $"`c.int`".int,
Review Comment:
The AttributeReferences created from these were previously treated as
single-part which is why I'm updating the test to actually make these
single-part (according to the comments on the test that's the expected
behaviour here).
We could decide to treat `$"...".int` as single-part instead, which maybe is
less of a change compared to the current behavior. But other tests rely on
producing multi-part identifiers with `$"left.a"`
[(here)](https://github.com/apache/spark/blob/87a5442f7ed96b11051d8a9333476d080054e5a0/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceOperatorSuite.scala#L180).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
