rshkv commented on code in PR #40902:
URL: https://github.com/apache/spark/pull/40902#discussion_r1174402747
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala:
##########
@@ -271,8 +271,9 @@ package object dsl {
override def expr: Expression = Literal(s)
def attr: UnresolvedAttribute = analysis.UnresolvedAttribute(s)
}
- implicit class DslAttr(attr: UnresolvedAttribute) extends
ImplicitAttribute {
- def s: String = attr.name
+ implicit class DslAttr(a: UnresolvedAttribute) extends ImplicitAttribute {
+ def s: String = a.name
+ override def attr: UnresolvedAttribute = a
Review Comment:
Yeah, this seems worth fixing.
Some tests have been relying on multi-part attributes implicitly becoming
single-part references. And we have to update those tests now to correct the
behavior for multi-part attributes. I don't know if you consider that a wider
break. It seems the DSL is solely used for testing, but technically these are
public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
