pengzhon-db commented on code in PR #40937:
URL: https://github.com/apache/spark/pull/40937#discussion_r1178398721
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -268,6 +268,12 @@ object SparkConnectService {
private val userSessionMapping =
cacheBuilder(CACHE_SIZE, CACHE_TIMEOUT_SECONDS).build[SessionCacheKey,
SessionHolder]()
+ private[connect] val streamingSessionManager =
+ new SparkConnectStreamingQueryCache(sessionKeepAliveFn = { case (userId,
sessionId) =>
+ userSessionMapping.getIfPresent((userId, sessionId))
+ // getIfPresent() prevents accidental loading.
Review Comment:
nit: I would put this comment line before the line 273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
