rangadi commented on code in PR #40937: URL: https://github.com/apache/spark/pull/40937#discussion_r1178495387
########## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamingQueryCache.scala: ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connect.service + +import java.util.concurrent.Executors +import java.util.concurrent.ScheduledExecutorService +import java.util.concurrent.TimeUnit +import javax.annotation.concurrent.GuardedBy + +import scala.collection.mutable +import scala.concurrent.duration.Duration +import scala.concurrent.duration.DurationInt +import scala.util.control.NonFatal + +import org.apache.spark.internal.Logging +import org.apache.spark.sql.SparkSession +import org.apache.spark.sql.streaming.StreamingQuery +import org.apache.spark.util.Clock +import org.apache.spark.util.SystemClock + +/** + * Caches Spark-Connect streaming query references and the sessions. When a query is stopped (i.e. + * no longer active), it is cached for 1 hour so that it is accessible from the client side. It + * runs a background thread to run a periodic task that does the following: + * - Check the status of the queries, and drops those that expired (1 hour after being stopped). + * - Keep the associated session active by invoking supplied function `sessionKeepAliveFn`. + * + * This class helps with supporting following semantics for streaming query sessions: Review Comment: This continuation of "outdated" comment thread about semantics : https://github.com/apache/spark/pull/40937#discussion_r1176846545 @HeartSaVioR could you take a look at this and may be bit of code too? This will help more streaming team review. cc: @HyukjinKwon . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
