Kimahriman commented on code in PR #40981:
URL: https://github.com/apache/spark/pull/40981#discussion_r1180404675
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -61,17 +60,27 @@ class RocksDB(
// Java wrapper objects linking to native RocksDB objects
private val readOptions = new ReadOptions() // used for gets
- private val writeOptions = new WriteOptions().setSync(true) // wait for
batched write to complete
Review Comment:
Is this not needed because when we zip things up we'll see anything in the
operating system cache anyway?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -348,9 +340,8 @@ class RocksDB(
* Drop uncommitted changes, and roll back to previous version.
*/
def rollback(): Unit = {
- closePrefixScanIterators()
- resetWriteBatch()
numKeysOnWritingVersion = numKeysOnLoadedVersion
+ loadedVersion = -1L
Review Comment:
Does any local files need to be cleaned up if they've been written to disk
during the task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
