anishshri-db commented on code in PR #40981: URL: https://github.com/apache/spark/pull/40981#discussion_r1180871653
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala: ########## @@ -61,17 +60,27 @@ class RocksDB( // Java wrapper objects linking to native RocksDB objects private val readOptions = new ReadOptions() // used for gets - private val writeOptions = new WriteOptions().setSync(true) // wait for batched write to complete Review Comment: Yea I don't think it was actually required even in the existing model. But with the new model, RocksDB library prevents using this option at all and throws this exception ``` [info] org.rocksdb.RocksDBException: Sync writes has to enable WAL. [info] at org.rocksdb.RocksDB.put(Native Method) [info] at org.rocksdb.RocksDB.put(RocksDB.java:904) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
