dtenedor commented on code in PR #40996:
URL: https://github.com/apache/spark/pull/40996#discussion_r1180841211
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##########
@@ -344,3 +358,13 @@ object ResolveDefaultColumns {
}
}
}
+
+/**
+ * Represents a table with an underlying raw schema to use for resolving
DEFAULT column references.
+ * The 'ignoreColumnsForInserts' field represents a set of column names to
exclude from
+ * consideration when performing INSERT INTO commands, if any.
+ */
+trait TableWithRawSchemaForColumnDefaults {
Review Comment:
We discussed offline, it's probably more straightforward to have the
separate trait that we only have to think about when it's relevant for specific
sources than in the core DSV2 API.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##########
@@ -344,3 +358,13 @@ object ResolveDefaultColumns {
}
}
}
+
+/**
+ * Represents a table with an underlying raw schema to use for resolving
DEFAULT column references.
+ * The 'ignoreColumnsForInserts' field represents a set of column names to
exclude from
Review Comment:
Good idea, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
