dtenedor commented on code in PR #40996:
URL: https://github.com/apache/spark/pull/40996#discussion_r1181933218
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##########
@@ -343,4 +363,11 @@ object ResolveDefaultColumns {
v1Catalog.isPersistentFunction(ident.asFunctionIdentifier)
}
}
+
+ trait CustomInsertSchema {
Review Comment:
@gengliangwang it needs to be visible from the `ResolveDefaultColumns` rule
which is under `package org.apache.spark.sql.catalyst.analysis`. That `package
org.apache.spark.sql.connector.write` is not visible in this way. Is there a
different package we should use instead?
I will add a test table that inherits this trait, and exercise it in the
unit tests and comment here again when ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
