WweiL commented on code in PR #40861:
URL: https://github.com/apache/spark/pull/40861#discussion_r1181915163
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -236,6 +237,9 @@ message StreamingQueryInstanceId {
// will generate a unique run_id. Therefore, every time a query is restarted
from
// checkpoint, it will have the same `id` but different `run_id`s.
string run_id = 2;
+
+ // (Optional) The name of this query.
+ optional string name = 3;
Review Comment:
Right I'm also not very sure here. Basically I added this because here:
https://github.com/apache/spark/blob/069caf4dcdb4380cd6eeca394b55824d5b71940a/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala#L2411
In the `sqm.get(queryID)` handler, the query may or may not have a name. But
in case it has, if we don't return the name then the client won't have it's
name.
We could also maintain a local cache of query names, but that would add more
complexity on cleaning up that cache though... What do you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
