rangadi commented on code in PR #40861:
URL: https://github.com/apache/spark/pull/40861#discussion_r1182043858


##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -238,15 +239,21 @@ message StreamingQueryInstanceId {
   string run_id = 2;
 }
 
+message StreamingQueryInstance {

Review Comment:
   Add a short comment. This name and `StreamingQueryInstanceId` might be 
confusing.
   May be we should remove the `name` field completely and make it an API call 
to server when it is needed (in a follow up). 
   For now, could you move it inside `StreamingQueryManagerCommand` as 
'GetQueryResult`? 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to