cloud-fan commented on code in PR #40989: URL: https://github.com/apache/spark/pull/40989#discussion_r1182000729
########## sql/core/src/test/resources/sql-tests/inputs/cte.sql: ########## @@ -53,6 +53,347 @@ SELECT * FROM t; WITH t AS (SELECT 1 FROM non_existing_table) SELECT 2; +-- The following tests are ported from Postgres Review Comment: We have many golden file test from postgres: `sql/core/src/test/resources/sql-tests/inputs/postgreSQL` Can you check if the new tests have duplication? ########## sql/core/src/test/resources/sql-tests/inputs/cte.sql: ########## @@ -53,6 +53,347 @@ SELECT * FROM t; WITH t AS (SELECT 1 FROM non_existing_table) SELECT 2; +-- The following tests are ported from Postgres Review Comment: We have many golden file test from postgres: `sql/core/src/test/resources/sql-tests/inputs/postgreSQL` Can you check if the new CTE tests have duplication? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
