RunyaoChen commented on code in PR #40989:
URL: https://github.com/apache/spark/pull/40989#discussion_r1185766487
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala:
##########
@@ -375,6 +390,8 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession with SQLHelper
val queries = tempQueries.map(_.trim).filter(_ != "").toSeq
// Fix misplacement when comment is at the end of the query.
.map(_.split("\n").filterNot(_.startsWith("--")).mkString("\n")).map(_.trim).filter(_
!= "")
+ // Expand the queries if it's CTETest
+ .flatMap(query => expandCTEQuery(query, testCase))
Review Comment:
Thanks, that's a good point. I now do this comparison for those non-command
queries with no exceptions. Since for queries with exception, the select from
view will always return `view not found`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
