gengliangwang commented on code in PR #40996:
URL: https://github.com/apache/spark/pull/40996#discussion_r1182927615
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##########
@@ -218,10 +219,29 @@ object ResolveDefaultColumns {
} else if (Cast.canUpCast(analyzed.dataType, dataType)) {
Cast(analyzed, dataType)
} else {
- throw new AnalysisException(
- s"Failed to execute $statementType command because the destination
table column " +
- s"$colName has a DEFAULT value with type $dataType, but the " +
- s"statement provided a value of incompatible type
${analyzed.dataType}")
+ // If the provided default value is a literal of a wider type than the
target column, but the
+ // literal value fits within the narrower type, just coerce it for
convenience.
+ val result = if (analyzed.isInstanceOf[Literal] &&
+ !Seq(dataType, analyzed.dataType).exists(_ == BooleanType)) {
+ try {
+ val casted = Cast(analyzed, dataType, evalMode = EvalMode.TRY).eval()
+ if (casted != null) {
+ Some(Literal(casted))
+ } else {
+ None
+ }
+ } catch {
+ case _: SparkThrowable | _: RuntimeException => None
Review Comment:
If it is TryCast, why would we need to use `try...cast` here? Shall we
simply check if the cast is `resolved` before eval?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
