dtenedor commented on code in PR #41021:
URL: https://github.com/apache/spark/pull/41021#discussion_r1183097205
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/datasketchesAggregates.scala:
##########
@@ -234,6 +237,9 @@ case class HllUnionAgg(
right.eval().asInstanceOf[Boolean]
}
+ // The default target type (register size) to use.
+ private val targetType = TgtHllType.HLL_8
Review Comment:
this is duplicated with L71 above, can we dedup to one place? Same for the
change in `datasketchesExpressions.scala`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
