mkaravel commented on code in PR #41021:
URL: https://github.com/apache/spark/pull/41021#discussion_r1183099184
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/datasketchesAggregates.scala:
##########
@@ -234,6 +237,9 @@ case class HllUnionAgg(
right.eval().asInstanceOf[Boolean]
}
+ // The default target type (register size) to use.
+ private val targetType = TgtHllType.HLL_8
Review Comment:
Let's do it in a follow up PR. I prefer that we merge this change ASAP and
then figure out how to refactor code properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
