hiboyang commented on PR #41036: URL: https://github.com/apache/spark/pull/41036#issuecomment-1538720811
> It would be great if you could just merge the change from my PR (just add the remote tree to your branch and merge the changes) and then push to your PR again. Right now, the Makefile is semi broken because you didn't mv the examples from examples to `cmd`. > > I took the project layout from: https://github.com/golang-standards/project-layout > > Now, for the package name we will have to refactor this a bit to make go get work. I think it should become: `https://github.com/apache/spark/connector/connect/client/go` > > We can use a versioning scheme similar to what arrow does. Got it, I am not super familiar with git commands to merge between different PRs, sorry for breaking here. I think now Makefile is good. I renamed to `https://github.com/apache/spark/connector/connect/client/go` in the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
