hvanhovell commented on code in PR #41123:
URL: https://github.com/apache/spark/pull/41123#discussion_r1190210933
##########
common/utils/src/main/scala/org/apache/spark/util/JsonUtils.scala:
##########
@@ -39,3 +39,5 @@ private[spark] object JsonUtils {
new String(baos.toByteArray, StandardCharsets.UTF_8)
}
}
+
Review Comment:
Some OCD is fine :). In this particular case you have the concrete
implementation of the InputStream, it is a stable implementation, and its
semantics are very well understood. I am fine with omitting the close because
of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
