amaliujia commented on code in PR #41123:
URL: https://github.com/apache/spark/pull/41123#discussion_r1190436826
##########
common/utils/src/main/scala/org/apache/spark/util/JsonUtils.scala:
##########
@@ -39,3 +39,5 @@ private[spark] object JsonUtils {
new String(baos.toByteArray, StandardCharsets.UTF_8)
}
}
+
Review Comment:
```
/**
* Closing a {@code ByteArrayOutputStream} has no effect. The methods in
* this class can be called after the stream has been closed without
* generating an {@code IOException}.
*/
public void close() throws IOException {
}
```
I guess probably we do not need to close (and this is existing code but just
refactor anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
