rednaxelafx commented on code in PR #41064: URL: https://github.com/apache/spark/pull/41064#discussion_r1190332445
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala: ########## @@ -79,7 +79,8 @@ case class LocalRelation( } override def computeStats(): Statistics = - Statistics(sizeInBytes = EstimationUtils.getSizePerRow(output) * data.length) + Statistics(sizeInBytes = EstimationUtils.getSizePerRow(output) * data.length, + rowCount = Some(data.size)) Review Comment: Post-hoc comment: not a big deal but I just noticed that we have `data.length` and `data.size` used on adjacent lines and they mean the same thing. It would have been better if we use the same method for the same thing, at least on the same page of code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
