rednaxelafx commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1190337492
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/joinReorder/JoinReorderSuite.scala:
##########
@@ -228,17 +228,16 @@ class JoinReorderSuite extends JoinReorderPlanTestBase
with StatsEstimationTestB
}
test("SPARK-26352: join reordering should not change the order of
attributes") {
Review Comment:
Thanks for the ping, the fact that the expected plan did change its join
order is good enough for the intent of the test. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
