itholic commented on code in PR #41211: URL: https://github.com/apache/spark/pull/41211#discussion_r1197445641
########## python/pyspark/pandas/tests/data_type_ops/test_date_ops.py: ########## @@ -61,6 +63,10 @@ def test_add(self): for psser in self.pssers: self.assertRaises(TypeError, lambda: self.psser + psser) + @unittest.skipIf( + LooseVersion(pd.__version__) >= LooseVersion("2.0.0"), + "TODO(SPARK-43571): Enable DateOpsTests.test_sub for pandas 2.0.0.", + ) Review Comment: Let me skip the tests for now, since there are numerous changes introduced in pandas 2.0.0, and most of them are related to behavior changes in the pandas API on Spark. In the current PR, our primary goal will be to prioritize support for pandas 2.0.0 in PySpark, and I don't want to introduce any behavior changes(There should be no behavior changes unless it is a major release). I already created bunch of tickets for enabling tests, so let me handle them in the follow-ups. Read https://github.com/apache/spark/pull/40658#issuecomment-1552517228 for more detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org