HyukjinKwon commented on code in PR #41211:
URL: https://github.com/apache/spark/pull/41211#discussion_r1197552394


##########
python/pyspark/pandas/tests/data_type_ops/test_date_ops.py:
##########
@@ -61,6 +63,10 @@ def test_add(self):
         for psser in self.pssers:
             self.assertRaises(TypeError, lambda: self.psser + psser)
 
+    @unittest.skipIf(
+        LooseVersion(pd.__version__) >= LooseVersion("2.0.0"),
+        "TODO(SPARK-43571): Enable DateOpsTests.test_sub for pandas 2.0.0.",
+    )

Review Comment:
   Yeah, because we depend on calling pandas right away in several API in 
pandas API on Spark. For example, this one 
https://github.com/apache/spark/pull/40658/files#diff-3d6777133e0de63c6dd3761a15d631d0c6520b918babf74522b0d95580954e72L908
   
   ```diff
            >>> ser.rename("a").to_frame().set_index("a").index.astype('int64')
   -        Int64Index([1, 2], dtype='int64', name='a')
   +        Index([1, 2], dtype='int64', name='a')
   ```
   
   Pandas returns a `Index` instead instead of `Int64Index` (see also 
https://pandas.pydata.org/docs/dev/whatsnew/v2.0.0.html#index-can-now-hold-numpy-numeric-dtypes).
   
   There is no `Int64Index` instance anymore in pandas.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to