cloud-fan commented on code in PR #34558:
URL: https://github.com/apache/spark/pull/34558#discussion_r1198528181
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala:
##########
@@ -130,6 +134,23 @@ case class LambdaFunction(
override def eval(input: InternalRow): Any = function.eval(input)
+ override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+ val functionCode = function.genCode(ctx)
Review Comment:
The code here is only to optimize the non-nullable case, which should be
handled by the function body codegen already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
