cloud-fan commented on code in PR #34558:
URL: https://github.com/apache/spark/pull/34558#discussion_r1198529114
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala:
##########
@@ -235,6 +256,53 @@ trait HigherOrderFunction extends Expression with
ExpectsInputTypes {
val canonicalizedChildren = cleaned.children.map(_.canonicalized)
withNewChildren(canonicalizedChildren)
}
+
+
+ protected def assignAtomic(atomicRef: String, value: String, isNull: String
= FalseLiteral,
+ nullable: Boolean = false) = {
+ if (nullable) {
+ s"""
+ if ($isNull) {
+ $atomicRef.set(null);
+ } else {
+ $atomicRef.set($value);
+ }
+ """
+ } else {
+ s"$atomicRef.set($value);"
+ }
+ }
+
+ protected def assignArrayElement(ctx: CodegenContext, arrayName: String,
elementCode: ExprCode,
+ elementVar: NamedLambdaVariable, index: String): String = {
+ val elementType = elementVar.dataType
+ val elementAtomic = ctx.addReferenceObj(elementVar.name, elementVar.value)
+ val extractElement = CodeGenerator.getValue(arrayName, elementType, index)
Review Comment:
With codegen, I don't think we need a global atomic reference to represent
the lambda variable. We can just generate local variables in the java code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
