Kimahriman commented on code in PR #34558:
URL: https://github.com/apache/spark/pull/34558#discussion_r1198914316
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala:
##########
@@ -130,6 +134,23 @@ case class LambdaFunction(
override def eval(input: InternalRow): Any = function.eval(input)
+ override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+ val functionCode = function.genCode(ctx)
Review Comment:
I'm trying to wrap my ahead around this again. I _think_ they might be doing
different things? Like for `ArrayTransform`, the `nullSafeCodeGen` is only
optimizing the non-nullable case of the result of `ArrayTransform`, whereas
this is optimizing the non-nullable case of the result of the lambda function
being called for each element in the `ArrayTransform`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
