Kimahriman commented on code in PR #34558:
URL: https://github.com/apache/spark/pull/34558#discussion_r1198915674
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala:
##########
@@ -130,6 +134,23 @@ case class LambdaFunction(
override def eval(input: InternalRow): Any = function.eval(input)
+ override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+ val functionCode = function.genCode(ctx)
Review Comment:
But maybe this already handles that:
```
val resultNull = if (function.nullable)
Some(functionCode.isNull.toString) else None
val resultAssignment = CodeGenerator.setArrayElement(arrayData,
dataType.elementType,
i, copy, isNull = resultNull)
```
I'll need to think about this a little more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
