szehon-ho commented on code in PR #41398:
URL: https://github.com/apache/spark/pull/41398#discussion_r1213333365


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala:
##########
@@ -57,6 +57,8 @@ case class ShuffledHashJoinExec(
 
   override def outputOrdering: Seq[SortOrder] = joinType match {
     case FullOuter => Nil
+    case LeftOuter if buildSide == BuildLeft => Nil
+    case RightOuter if buildSide == BuildRight => Nil

Review Comment:
   Sure, added a comment as per my understanding (please let me know if I 
misunderstand something)
   
   My thought was, because the second iteration on the build-side (for 
outer-join semantic) is on a hashedRelation, the result cannot be in order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to