huaxingao commented on code in PR #41398:
URL: https://github.com/apache/spark/pull/41398#discussion_r1213345816
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala:
##########
@@ -219,14 +238,15 @@ case class ShuffledHashJoinExec(
* the value indices of its tuples will be 0, 1 and 2.
* Note that value indices of tuples with different keys are incomparable.
*/
- private def fullOuterJoinWithNonUniqueKey(
+ private def buildSideOuterJoinNonUniqueKey(
streamIter: Iterator[InternalRow],
hashedRelation: HashedRelation,
joinKeys: UnsafeProjection,
joinRowWithStream: InternalRow => JoinedRow,
joinRowWithBuild: InternalRow => JoinedRow,
streamNullJoinRowWithBuild: => InternalRow => JoinedRow,
- buildNullRow: GenericInternalRow): Iterator[InternalRow] = {
+ buildNullRow: GenericInternalRow,
+ full: Boolean): Iterator[InternalRow] = {
Review Comment:
`full` -> `isFullOuterJoin`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
