cloud-fan commented on code in PR #40908:
URL: https://github.com/apache/spark/pull/40908#discussion_r1213790789
##########
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -318,7 +318,7 @@ query
insertInto
: INSERT OVERWRITE TABLE? identifierReference (partitionSpec (IF NOT
EXISTS)?)? identifierList? #insertOverwriteTable
- | INSERT INTO TABLE? identifierReference partitionSpec? (IF NOT EXISTS)?
identifierList? #insertIntoTable
+ | INSERT INTO TABLE? identifierReference partitionSpec? (BY NAME)? (IF NOT
EXISTS)? identifierList? #insertIntoTable
Review Comment:
shall we do`((BY NAME) | identifierList)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
