cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217471514
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala: ########## @@ -274,15 +274,16 @@ class FindDataSourceTable(sparkSession: SparkSession) extends Rule[LogicalPlan] override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators { - case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, options, false), - _, _, _, _, _) if DDLUtils.isDatasourceTable(tableMeta) => + case i@InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, options, false), + _, _, _, _, _, _) if DDLUtils.isDatasourceTable(tableMeta) => i.copy(table = readDataSourceTable(tableMeta, options)) - case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, _, false), _, _, _, _, _) => + case i@InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, _, false), Review Comment: ```suggestion case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, _, false), ``` ########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala: ########## @@ -274,15 +274,16 @@ class FindDataSourceTable(sparkSession: SparkSession) extends Rule[LogicalPlan] override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators { - case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, options, false), - _, _, _, _, _) if DDLUtils.isDatasourceTable(tableMeta) => + case i@InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, options, false), + _, _, _, _, _, _) if DDLUtils.isDatasourceTable(tableMeta) => i.copy(table = readDataSourceTable(tableMeta, options)) - case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, _, false), _, _, _, _, _) => + case i@InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, _, false), + _, _, _, _, _, _) => Review Comment: ```suggestion _, _, _, _, _, _) => ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org