szehon-ho commented on code in PR #41398:
URL: https://github.com/apache/spark/pull/41398#discussion_r1214043949
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala:
##########
@@ -83,8 +88,10 @@ case class ShuffledHashJoinExec(
iter,
buildBoundKeys,
taskMemoryManager = context.taskMemoryManager(),
- // Full outer join needs support for NULL key in HashedRelation.
- allowsNullKey = joinType == FullOuter,
+ // build-side outer join needs support for NULL key in HashedRelation.
Review Comment:
I see how it may be read that way, let me clarify it. I was originally
hoping to find one phrase to capture full-outer join, right-outer + buildRight
, left-outer + buildLeft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
