viirya commented on code in PR #41398:
URL: https://github.com/apache/spark/pull/41398#discussion_r1214000680
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala:
##########
@@ -83,8 +88,10 @@ case class ShuffledHashJoinExec(
iter,
buildBoundKeys,
taskMemoryManager = context.taskMemoryManager(),
- // Full outer join needs support for NULL key in HashedRelation.
- allowsNullKey = joinType == FullOuter,
+ // build-side outer join needs support for NULL key in HashedRelation.
Review Comment:
`build-side outer join` sounds like left-outer or right-outer join
specially. For full outer join, right/left side both can be build side, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
