vicennial commented on code in PR #41357:
URL: https://github.com/apache/spark/pull/41357#discussion_r1217977040
##########
python/pyspark/sql/connect/client/artifact.py:
##########
@@ -187,6 +188,19 @@ def _parse_artifacts(self, path_or_uri: str, pyfile: bool,
archive: bool) -> Lis
return [artifact]
raise RuntimeError(f"Unsupported scheme: {parsed.scheme}")
+ def _parse_forward_to_fs_artifacts(self, local_path: str, dest_path: str)
-> List[Artifact]:
+ local_path = Path(local_path).absolute()
+ # TODO: Support directory path.
+ assert local_path.is_file(), "local path must be a file path."
+ storage = LocalFile(str(local_path))
+
+ assert Path(dest_path).is_absolute(), "destination FS path must be an
absolut path."
Review Comment:
Nit: Typo `absolut`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
