LuciferYang commented on code in PR #41477: URL: https://github.com/apache/spark/pull/41477#discussion_r1220755529
########## python/pyspark/sql/connect/functions.py: ########## @@ -2373,6 +2374,109 @@ def hours(col: "ColumnOrName") -> Column: hours.__doc__ = pysparkfuncs.hours.__doc__ + +def make_dt_interval( Review Comment: Scala side code is fine to me, need someone familiar with python for further review ########## python/pyspark/sql/connect/functions.py: ########## @@ -2373,6 +2374,109 @@ def hours(col: "ColumnOrName") -> Column: hours.__doc__ = pysparkfuncs.hours.__doc__ + +def make_dt_interval( Review Comment: Scala code is fine to me, need someone familiar with python for further review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
