zhengruifeng commented on code in PR #41477: URL: https://github.com/apache/spark/pull/41477#discussion_r1221186755
########## python/pyspark/sql/connect/functions.py: ########## @@ -2373,6 +2374,117 @@ def hours(col: "ColumnOrName") -> Column: hours.__doc__ = pysparkfuncs.hours.__doc__ + +def make_dt_interval( + days: Optional["ColumnOrName"] = None, + hours: Optional["ColumnOrName"] = None, + mins: Optional["ColumnOrName"] = None, + secs: Optional["ColumnOrName"] = None, Review Comment: since `days`/`hours`/`minus` accepts `IntegerType` column, and `secs ` accepts `DecimalType`; shall we make `days`/`hours`/`minus`: `Union["ColumnOrName", int]` and `secs` : `Union["ColumnOrName", float, decimal. Decimal]` ? e.g. https://github.com/apache/spark/blob/747db6675da86e79d04e2fcc531b3b72b22ebf04/python/pyspark/sql/functions.py#L4757 ########## python/pyspark/sql/connect/functions.py: ########## @@ -2373,6 +2374,117 @@ def hours(col: "ColumnOrName") -> Column: hours.__doc__ = pysparkfuncs.hours.__doc__ + +def make_dt_interval( + days: Optional["ColumnOrName"] = None, + hours: Optional["ColumnOrName"] = None, + mins: Optional["ColumnOrName"] = None, + secs: Optional["ColumnOrName"] = None, Review Comment: also cc @HyukjinKwon ########## python/pyspark/sql/connect/functions.py: ########## @@ -2373,6 +2374,117 @@ def hours(col: "ColumnOrName") -> Column: hours.__doc__ = pysparkfuncs.hours.__doc__ + +def make_dt_interval( + days: Optional["ColumnOrName"] = None, + hours: Optional["ColumnOrName"] = None, + mins: Optional["ColumnOrName"] = None, + secs: Optional["ColumnOrName"] = None, Review Comment: it seems in this PR, users can use in this way ``` make_dt_interval(mins="col_a") // skip `days` ``` while this usage is not supported on the Scala side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
