dongjoon-hyun commented on code in PR #41499:
URL: https://github.com/apache/spark/pull/41499#discussion_r1221854936
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala:
##########
@@ -413,11 +423,19 @@ trait JoinSelectionHelper {
}
def hintToNotBroadcastLeft(hint: JoinHint): Boolean = {
Review Comment:
This method name seems to mismatch with the content because of the missing
`NO_BROADCAST_AND_REPLICATION`.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala:
##########
@@ -413,11 +423,19 @@ trait JoinSelectionHelper {
}
def hintToNotBroadcastLeft(hint: JoinHint): Boolean = {
- hint.leftHint.exists(_.strategy.contains(NO_BROADCAST_HASH))
+ hint.leftHint.flatMap(_.strategy).exists {
+ case NO_BROADCAST_HASH => true
+ case NO_BROADCAST_AND_REPLICATION => true
+ case _ => false
+ }
}
def hintToNotBroadcastRight(hint: JoinHint): Boolean = {
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
